Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retro review of 4302 #4337

Merged
merged 2 commits into from
Sep 24, 2024
Merged

retro review of 4302 #4337

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0c7a2e
retro review of 4302
christinaausley Sep 23, 2024
6323458
Merge branch 'main' into retro-4302
leiicamundi Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/self-managed/setup/deploy/amazon/amazon-eks/eksctl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ metadata:
region: ${REGION:-eu-central-1} # e.g. eu-central-1
version: "1.28"
availabilityZones:
- ${REGION:-eu-central-1}c # e.g. eu-central-1c, the minimal is 2 distinct Availability Zones (AZs) within the region
- ${REGION:-eu-central-1}c # e.g. eu-central-1c, the minimal is two distinct Availability Zones (AZs) within the region
- ${REGION:-eu-central-1}b
- ${REGION:-eu-central-1}a
cloudWatch:
Expand Down
20 changes: 10 additions & 10 deletions docs/self-managed/setup/deploy/amazon/amazon-eks/irsa.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Replace `<REGION>`, `<ACCOUNT-ID>`, `<DB-RESOURCE-ID>`, and `<DB-USERNAME>` with

<TabItem value="aws-cli" label="AWS CLI">

To create the AWS policy using the AWS CLI, you can use the `aws iam create-policy` command. Here’s an example:
To create the AWS policy using the AWS CLI, use the `aws iam create-policy` command:

```bash
aws iam create-policy \
Expand Down Expand Up @@ -86,7 +86,7 @@ Replace `<REGION>`, `<ACCOUNT-ID>`, `<DB-RESOURCE-ID>`, and `<DB-USERNAME>` with
<Tabs>
<TabItem value="terraform" label="Terraform" default>

To assign the policy to a role for IAM role to service account mapping in Amazon EKS, you can use a Terraform module like [iam-role-for-service-accounts-eks](https://registry.terraform.io/modules/terraform-aws-modules/iam/aws/latest/submodules/iam-role-for-service-accounts-eks). Here’s an example configuration:
To assign the policy to a role for IAM role to service account mapping in Amazon EKS, use a Terraform module like [iam-role-for-service-accounts-eks](https://registry.terraform.io/modules/terraform-aws-modules/iam/aws/latest/submodules/iam-role-for-service-accounts-eks):
leiicamundi marked this conversation as resolved.
Show resolved Hide resolved

```json
module "aurora_role" {
Expand Down Expand Up @@ -114,7 +114,7 @@ This Terraform snippet creates a role that allows the service account `<AURORA-S

To assign the policy to a role using the AWS CLI, follow these steps:

1. **Create the IAM Role**:
1. **Create the IAM role**:

```bash
aws iam create-role \
Expand All @@ -138,7 +138,7 @@ aws iam create-role \
}'
```

2. **Attach the Policy to the Role**:
2. **Attach the policy to the role**:

```bash
aws iam attach-role-policy \
Expand All @@ -149,7 +149,7 @@ aws iam attach-role-policy \
</TabItem>
</Tabs>

You need to annotate the service account with the `iam_role_arn`. Here is an example YAML configuration:
Annotate the service account with the `iam_role_arn`:

```yaml
apiVersion: v1
Expand Down Expand Up @@ -388,7 +388,7 @@ Replace `<REGION>`, `<ACCOUNT-ID>`, and `<DOMAIN-NAME>` with the appropriate val

<TabItem value="aws-cli" label="AWS CLI">

To create an AWS policy for Amazon OpenSearch Service using the AWS CLI, you can use the `aws iam create-policy` command. Here’s an example:
To create an AWS policy for Amazon OpenSearch Service using the AWS CLI, you use the `aws iam create-policy` command:

```bash
aws iam create-policy \
Expand Down Expand Up @@ -440,7 +440,7 @@ To assign the policy to a role for the IAM role to service account mapping in Am
<Tabs>
<TabItem value="terraform" label="Terraform" default>

You can use a Terraform module like [iam-role-for-service-accounts-eks](https://registry.terraform.io/modules/terraform-aws-modules/iam/aws/latest/submodules/iam-role-for-service-accounts-eks). Here’s an example configuration:
You can use a Terraform module like [iam-role-for-service-accounts-eks](https://registry.terraform.io/modules/terraform-aws-modules/iam/aws/latest/submodules/iam-role-for-service-accounts-eks):

```json
module "opensearch_role" {
Expand Down Expand Up @@ -470,7 +470,7 @@ Annotate the service account with the `iam_role_arn` output.

To assign the policy to a role using the AWS CLI, follow these steps:

1. **Create the IAM Role**:
1. **Create the IAM role**:

```bash
aws iam create-role \
Expand All @@ -494,7 +494,7 @@ aws iam create-role \
}'
```

2. **Attach the Policy to the Role**:
2. **Attach the policy to the role**:

```bash
aws iam attach-role-policy \
Expand All @@ -505,7 +505,7 @@ aws iam attach-role-policy \
</TabItem>
</Tabs>

You need to annotate the service account with the `iam_role_arn`. Here is an example YAML configuration:
Annotate the service account with the `iam_role_arn`:

```yaml
apiVersion: v1
Expand Down
2 changes: 1 addition & 1 deletion versioned_docs/version-8.5/self-managed/setup/deploy/amazon/amazon-eks/eksctl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ metadata:
region: ${REGION:-eu-central-1} # e.g. eu-central-1
version: "1.28"
availabilityZones:
- ${REGION:-eu-central-1}c # e.g. eu-central-1c, the minimal is 2 distinct Availability Zones (AZs) within the region
- ${REGION:-eu-central-1}c # e.g. eu-central-1c, the minimal is two distinct Availability Zones (AZs) within the region
- ${REGION:-eu-central-1}b
- ${REGION:-eu-central-1}a
cloudWatch:
Expand Down
20 changes: 10 additions & 10 deletions versioned_docs/version-8.5/self-managed/setup/deploy/amazon/amazon-eks/irsa.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Replace `<REGION>`, `<ACCOUNT-ID>`, `<DB-RESOURCE-ID>`, and `<DB-USERNAME>` with

<TabItem value="aws-cli" label="AWS CLI">

To create the AWS policy using the AWS CLI, you can use the `aws iam create-policy` command. Here’s an example:
To create the AWS policy using the AWS CLI, use the `aws iam create-policy` command:

```bash
aws iam create-policy \
Expand Down Expand Up @@ -86,7 +86,7 @@ Replace `<REGION>`, `<ACCOUNT-ID>`, `<DB-RESOURCE-ID>`, and `<DB-USERNAME>` with
<Tabs>
<TabItem value="terraform" label="Terraform" default>

To assign the policy to a role for IAM role to service account mapping in Amazon EKS, you can use a Terraform module like [iam-role-for-service-accounts-eks](https://registry.terraform.io/modules/terraform-aws-modules/iam/aws/latest/submodules/iam-role-for-service-accounts-eks). Here’s an example configuration:
To assign the policy to a role for IAM role to service account mapping in Amazon EKS, use a Terraform module like [iam-role-for-service-accounts-eks](https://registry.terraform.io/modules/terraform-aws-modules/iam/aws/latest/submodules/iam-role-for-service-accounts-eks):

```json
module "aurora_role" {
Expand Down Expand Up @@ -114,7 +114,7 @@ This Terraform snippet creates a role that allows the service account `<AURORA-S

To assign the policy to a role using the AWS CLI, follow these steps:

1. **Create the IAM Role**:
1. **Create the IAM role**:

```bash
aws iam create-role \
Expand All @@ -138,7 +138,7 @@ aws iam create-role \
}'
```

2. **Attach the Policy to the Role**:
2. **Attach the policy to the role**:

```bash
aws iam attach-role-policy \
Expand All @@ -149,7 +149,7 @@ aws iam attach-role-policy \
</TabItem>
</Tabs>

You need to annotate the service account with the `iam_role_arn`. Here is an example YAML configuration:
Annotate the service account with the `iam_role_arn`:

```yaml
apiVersion: v1
Expand Down Expand Up @@ -388,7 +388,7 @@ Replace `<REGION>`, `<ACCOUNT-ID>`, and `<DOMAIN-NAME>` with the appropriate val

<TabItem value="aws-cli" label="AWS CLI">

To create an AWS policy for Amazon OpenSearch Service using the AWS CLI, you can use the `aws iam create-policy` command. Here’s an example:
To create an AWS policy for Amazon OpenSearch Service using the AWS CLI, use the `aws iam create-policy` command:

```bash
aws iam create-policy \
Expand Down Expand Up @@ -440,7 +440,7 @@ To assign the policy to a role for the IAM role to service account mapping in Am
<Tabs>
<TabItem value="terraform" label="Terraform" default>

You can use a Terraform module like [iam-role-for-service-accounts-eks](https://registry.terraform.io/modules/terraform-aws-modules/iam/aws/latest/submodules/iam-role-for-service-accounts-eks). Here’s an example configuration:
You can use a Terraform module like [iam-role-for-service-accounts-eks](https://registry.terraform.io/modules/terraform-aws-modules/iam/aws/latest/submodules/iam-role-for-service-accounts-eks):

```json
module "opensearch_role" {
Expand Down Expand Up @@ -470,7 +470,7 @@ Annotate the service account with the `iam_role_arn` output.

To assign the policy to a role using the AWS CLI, follow these steps:

1. **Create the IAM Role**:
1. **Create the IAM role**:

```bash
aws iam create-role \
Expand All @@ -494,7 +494,7 @@ aws iam create-role \
}'
```

2. **Attach the Policy to the Role**:
2. **Attach the policy to the role**:

```bash
aws iam attach-role-policy \
Expand All @@ -505,7 +505,7 @@ aws iam attach-role-policy \
</TabItem>
</Tabs>

You need to annotate the service account with the `iam_role_arn`. Here is an example YAML configuration:
Annotate the service account with the `iam_role_arn`:

```yaml
apiVersion: v1
Expand Down
Loading