Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retro review of 4302 #4337

Merged
merged 2 commits into from
Sep 24, 2024
Merged

retro review of 4302 #4337

merged 2 commits into from
Sep 24, 2024

Conversation

christinaausley
Copy link
Contributor

Description

Retro review of #4302.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added the component:docs Documentation improvements, including new or updated content label Sep 23, 2024
@christinaausley christinaausley requested review from leiicamundi and a team September 23, 2024 16:43
@christinaausley christinaausley self-assigned this Sep 23, 2024
Copy link
Contributor

@leiicamundi leiicamundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @christinaausley, thanks for the retro-review :) I left a single comment

Otherwise, lgtm

Copy link
Contributor

@leiicamundi leiicamundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when you want @christinaausley, and thanks the update

@christinaausley christinaausley merged commit dea3d4a into main Sep 24, 2024
7 checks passed
@christinaausley christinaausley deleted the retro-4302 branch September 24, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants