Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/category-creation-position #814

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

henriquecbuss
Copy link
Member

What issue does this PR close

Closes N/A. We're talking about this on Slack: https://cambiatus.slack.com/archives/CA83HJAAD/p1660676306254949 and https://cambiatus.slack.com/archives/CA83HJAAD/p1660648202151329

Changes Proposed ( a list of new changes introduced by this PR)

  • Send the correct position (instead of always sending 0)
  • Order categories by position

How to test ( a list of instructions on how to test this PR)

Try to create new categories!

@netlify
Copy link

netlify bot commented Aug 17, 2022

Deploy Preview for cambiatus-elm-book ready!

Name Link
🔨 Latest commit 4e5242b
🔍 Latest deploy log https://app.netlify.com/sites/cambiatus-elm-book/deploys/62fd3f5890d4400008af8044
😎 Deploy Preview https://deploy-preview-814--cambiatus-elm-book.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 17, 2022

Deploy done!

Name Link
🔨 Latest commit 4e5242b
🔍 Latest deploy log https://app.netlify.com/sites/cambiatus/deploys/62fd3f58eb18fd0009e248c6
😎 Deploy Preview https://deploy-preview-814--cambiatus.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@henriquecbuss henriquecbuss self-assigned this Aug 17, 2022
@henriquecbuss
Copy link
Member Author

henriquecbuss commented Aug 18, 2022

@lucca65 do you think we should wait for cambiatus/backend#283 (specifically the bug about creating categories in communities that don't have them - is it gonna be dealt with in that PR?), or can we merge this one?

@henriquecbuss henriquecbuss merged commit 2425d86 into master Aug 19, 2022
@henriquecbuss henriquecbuss deleted the fix/category-creation-position branch August 19, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants