Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/product category fixes #283

Merged
merged 5 commits into from
Aug 19, 2022
Merged

Fix/product category fixes #283

merged 5 commits into from
Aug 19, 2022

Conversation

lucca65
Copy link
Member

@lucca65 lucca65 commented Aug 16, 2022

What issue does this PR close

Closes N/A

Changes Proposed ( a list of new changes introduced by this PR)

  • Fixes error that would be raised when we try to delete a category already associated with a product. Now it deletes the association with the product.

How to test ( a list of instructions on how to test this PR)

run mix test there are test cases for those bugs

@lucca65 lucca65 added the 🐞 bug Something isn't working label Aug 16, 2022
@lucca65 lucca65 added this to the 🧹 Housekeeping milestone Aug 16, 2022
@henriquecbuss
Copy link
Member

@lucca65
Copy link
Member Author

lucca65 commented Aug 18, 2022

Não bro, adicionei um teste com os mesmos parâmetros e o erro não aparece. Coloquei uma captura do Sentry pra tentar entender oq tá rolando

@henriquecbuss
Copy link
Member

@lucca65 fiz o deploy em staging e consegui forçar o erro de novo. Apareceu no Sentry aqui: https://sentry.io/organizations/cambiatus/issues/3506056096/. Acho que não diz muita coisa a mais 😬

Copy link
Member

@henriquecbuss henriquecbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@lucca65 lucca65 merged commit 1302876 into master Aug 19, 2022
@lucca65 lucca65 deleted the Fix/product-category-fixes branch August 19, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants