Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/pin hidden #628

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Enhancement/pin hidden #628

merged 4 commits into from
Aug 24, 2021

Conversation

henriquecbuss
Copy link
Member

What issue does this PR close

Closes #589

Changes Proposed ( a list of new changes introduced by this PR)

  • Default the PIN to hidden
  • Use localStorage when the USE_SUBDOMAIN flag is set to false. This way we can actually have some persistence, especially on Netlify deploys
  • When the user submits their PIN, save (on localStorage/cookies) if it should be hidden or shown on the next time their PIN is requested

How to test ( a list of instructions on how to test this PR)

  1. Be logged out
  2. When you enter your PIN, it should be hidden. If you change it to visible, the next time you enter your pin anywhere on the app, it should be visible, etc. That should work with any PIN request.

Your PIN may be requested on login, when you're changing your PIN on your profile page, or when you're signing blockchain transactions (such as approving a claim, buying a product, transferring to a friend, etc.). Note that if you're logged in, we remember your PIN from the first time you enter it, and don't ask for it again until you refresh the page.

lucca65
lucca65 previously approved these changes Aug 23, 2021
Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice! 🏗️

@henriquecbuss henriquecbuss merged commit 5da0231 into master Aug 24, 2021
@henriquecbuss henriquecbuss deleted the enhancement/pin-hidden branch August 24, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the PIN as hidden by default
2 participants