Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the PIN as hidden by default #589

Closed
lucca65 opened this issue Jul 13, 2021 · 3 comments · Fixed by #628
Closed

Make the PIN as hidden by default #589

lucca65 opened this issue Jul 13, 2021 · 3 comments · Fixed by #628
Assignees
Labels
🧰 enhancement Changes and improvements to what we already have 👶 good first issue Good for newcomers

Comments

@lucca65
Copy link
Member

lucca65 commented Jul 13, 2021

What we have
Today the default of the pin is to be shown, the user can toggle this to change to hidden

Proposal
Default the value to hidden

Why
To improve privacy

How
N/A

Additional context
Discovered during our Full Team session

@lucca65 lucca65 added 🧰 enhancement Changes and improvements to what we already have 👶 good first issue Good for newcomers labels Jul 13, 2021
@henriquecbuss
Copy link
Member

Maybe we could also remember the choice of the user. So if they choose to show it, it should be shown the next times their PIN is requested, and the same if they choose to hide it

@lucca65
Copy link
Member Author

lucca65 commented Jul 13, 2021

nice! this would be nice! If possible, can we have a full list of preferences? I'm thinking to persist some of them in our backend on cambiatus/backend#172

I'm thinking some stuff like languages, that can affect the language of the emails

@henriquecbuss
Copy link
Member

Can't think of much else... Other than the language, maybe the timezone could be useful for sending emails at appropriate times? Not sure...

I think the PIN preference could be stored only in localStorage, no? The only other thing I can think of is search words, but idk how useful that would be on the backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 enhancement Changes and improvements to what we already have 👶 good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants