Enhancement/elm review #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriquecbuss
requested review from
lucca65,
adubas,
alanrrb,
andregomesb,
victorgdev and
zederson
lucca65
approved these changes
Jun 3, 2021
|
|
||
| "Bananas" :: _ -> | ||
| Nothing | ||
|
|
| [ "ChecksLoaded", UR.remoteDataToString r ] | ||
| [ "ClaimsLoaded", UR.remoteDataToString r ] |
| , responseData = Encode.null | ||
| , data = | ||
| Encode.object | ||
| [ ( "name", Encode.string "openChat" ) |
There was a problem hiding this comment.
open chat 🤯 damn its been so long
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR close
Closes #527
Changes Proposed ( a list of new changes introduced by this PR)
NoDebug.LogNoDebug.TodoOrToStringNoUnused.VariablesNoUnused.ModulesNoBooleanCaseNoExposingEverythingNoUnused.CustomTypeConstructorsNoUnsued.CustomTypeConstructorArgsNoUnused.ExportsNoMissingTypeAnnotationSimplifyNoLeftPizzaUseCamelCaseNoModuleOnExposedNamesNoRedundantConcatNoRedundantConsNoInconsistentJsAddressToMsgNoInconsistentMsgToStringHow to test ( a list of instructions on how to test this PR)
You can test our project's specific rules by running
elm-testunder thereviewdirectory (you might need to installelm-test:npm install --global elm-test).Otherwise, you can see results from
yarn review(it's also available as a check in GitHub) and just look through the changes and see if you spot anything weird. Browse around the app and see if the behaviour is still the same (shouldn't have changed a thing)