Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve elm-review rules #527

Closed
henriquecbuss opened this issue May 5, 2021 · 0 comments · Fixed by #553
Closed

Improve elm-review rules #527

henriquecbuss opened this issue May 5, 2021 · 0 comments · Fixed by #553
Assignees
@henriquecbuss
Labels
🧰 enhancement Changes and improvements to what we already have

Comments

@henriquecbuss
Copy link
Member

What we have
Our elm-review rules are very simple right now, which means we still have a lot of unused code. Running npx elm-review --template jfmengels/elm-review-unused/example gives us around 700 errors

Proposal
We should use stronger rules so we prevent more dead code, have simpler code and some more guarantees

Why

  • Eliminate dead code
  • Simplify code
  • Have some guarantees. e.g. make sure functions like msgToString are correct

How
N/A

Additional context
Inspired by this post by the creator of elm-review
@henriquecbuss henriquecbuss added the 🧰 enhancement Changes and improvements to what we already have label May 5, 2021
@henriquecbuss henriquecbuss mentioned this issue Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henriquecbuss henriquecbuss

Labels
🧰 enhancement Changes and improvements to what we already have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement/elm review cambiatus/frontend
1 participant
@henriquecbuss