Prepare release r1.2 #45

jgarciahospital · 2024-08-23T11:01:06Z

What type of PR is this?

Add one of the following kinds:

subproject management

What this PR does / why we need it:

Prepare the release 1.2 with the required changes.

Which issue(s) this PR fixes:

Fixes #35
Related to #44

Special notes for reviewers:

Pending to include #44 before merging this PR

hdamker

Some suggestions and one needed change in YAML to be aligned with ICM 0.2.0

CHANGELOG.md

hdamker · 2024-08-23T14:57:02Z

CHANGELOG.md

+* Include testing definitions in .feature file for Fall24 meta-release by @jgarciahospital in https://github.com/camaraproject/PopulationDensityData/pull/44
+
+### Changed
+* N/A


Wouldn't be #42 worth to mention here? ... it updated not only the description within the info object but the complete inline documentation across the API definition.

Included, sorry I missed to report previous PRs from rc1.1

hdamker · 2024-08-23T15:01:13Z

documentation/API_documentation/Population-Density-Data-API-Readiness-Checklist.md

@@ -10,7 +10,7 @@ Checklist for population-density-data 0.1.1-rc.1 in release r1.1
 |  4 | API versioning convention applied            |   M   |         M         |    M    |    M   |  Y   |      |
 |  5 | API documentation                            |   M   |         M         |    M    |    M   |  Y   | Embed documentation into API spec - [link](/code/API_definitions/population-density-data.yaml) |
 |  6 | User stories                                 |   O   |         O         |    O    |    M   |  N   |      |
-|  7 | Basic API test cases & documentation         |   O   |         M         |    M    |    M   |  Pending   |  |
+|  7 | Basic API test cases & documentation         |   O   |         M         |    M    |    M   |  Y  | Included in Test PR#44 |


Need to be updated after the merge of #44 or you anticipate here the link.

Yes, I didn't make any change in the table since #44 is also modifying that part of the file, avoiding conflicts.

documentation/API_documentation/Population-Density-Data-API-Readiness-Checklist.md

CHANGELOG.md

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

…adiness-Checklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

bigludo7 · 2024-09-05T17:04:57Z

@jgarciahospital - to be sure we're aligned.
I've added easy comments to fix for #44 & #47 - we solve them & merge them first and then we close this one - work for you?

jgarciahospital · 2024-09-05T17:30:03Z

@jgarciahospital - to be sure we're aligned. I've added easy comments to fix for #44 & #47 - we solve them & merge them first and then we close this one - work for you?

Thanks Ludovic for the review, comments applied in #44 and #47 and pending to be merged before close release PR.
Please @sachinvodafone for your validation

tanjadegroot · 2024-09-06T17:43:39Z

I spotted a bug in the version used in the test file- see comment on #44

jgarciahospital · 2024-09-06T19:03:08Z

I spotted a bug in the version used in the test file- see comment on #44

Thanks @tanjadegroot , solved.

For information, API readiness checklist filename will be maintained as fixed in #44 after merging this PR

hdamker · 2024-09-09T14:47:34Z

@jgarciahospital @maheshc01 @sachinvodafone I approved the changes to remove the block from requested changes (they are addressed - thanks!). For me everything here looks good, but #44 and #47 need still to be approved and merged first. Would be good if you can do that asap so that we get this release still into the Meta-Release (we need to prepare the communication material the next days ... as M5 is approaching).

…on-density-data-API-Readiness-Checklist.md

hdamker

Great - LGTM.

The one point I found is not really relevant, but just confused me, as I know that the latest change was in ICM v0.2.0-rc.2 (which you have correctly applied already in r1.1)

CHANGELOG.md

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

jgarciahospital · 2024-09-11T14:02:22Z

Great - LGTM.

The one point I found is not really relevant, but just confused me, as I know that the latest change was in ICM v0.2.0-rc.2 (which you have correctly applied already in r1.1)

Included for clarity, thanks @hdamker

bigludo7

LGTM
Thanks @jgarciahospital

tanjadegroot · 2024-09-11T15:19:16Z

@sachinvodafone @gregory1g @maheshc01 @rartych please review this PR, create the API release and update the API release tracker - we want to close the M4 today please :-)

hdamker · 2024-09-11T15:34:52Z

@jgarciahospital if the lack of an code owner review is blocking you, let me know and I help to merge. I see that @sachinvodafone has multiple times approved previously.

jgarciahospital · 2024-09-11T16:11:42Z

@jgarciahospital if the lack of an code owner review is blocking you, let me know and I help to merge. I see that @sachinvodafone has multiple times approved previously.

Conscious that API review was made during last meeting, and that we have at least one other company's approval, we can wait until tomorrow for a code owner approval or move directly if @hdamker you want to close today the milestone.

tanjadegroot · 2024-09-11T17:06:33Z

Approval on this PR from Release Management: LGTM

hdamker · 2024-09-11T17:19:20Z

Conscious that API review was made during last meeting, and that we have at least one other company's approval, we can wait until tomorrow for a code owner approval or move directly if @hdamker you want to close today the milestone.

We want to close today 👍

With the additional approval from @tanjadegroot I suppose we are good to go, will merge.
@jgarciahospital may you take the creation of the release and the update of the release tracker?

jgarciahospital added 5 commits August 23, 2024 12:33

Update version and servers URL for initial version

032cd5f

Delete documentation/API_documentation/README.MD

fed1952

Update Checklist for r1.2

888e848

Update README.md for rc.1.2

3a47715

Update CHANGELOG for R1.2

d4ae577

jgarciahospital added Fall24 RC2 labels Aug 23, 2024

jgarciahospital requested a review from a team August 23, 2024 11:01

jgarciahospital requested review from sachinvodafone and maheshc01 as code owners August 23, 2024 11:01

hdamker requested changes Aug 23, 2024

View reviewed changes

hdamker mentioned this pull request Aug 23, 2024

PopulationDensityData r1.2 release review (M4) camaraproject/ReleaseManagement#80

Closed

11 tasks

jgarciahospital and others added 3 commits August 24, 2024 13:30

Update CHANGELOG.md

02214df

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update documentation/API_documentation/Population-Density-Data-API-Re…

83b737b

…adiness-Checklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Including r1.1 changes in r1.2 report

8e7bc02

jgarciahospital requested a review from hdamker August 24, 2024 11:46

jgarciahospital mentioned this pull request Sep 4, 2024

Create Gherkin tests for Population Density Data #44

Merged

hdamker previously approved these changes Sep 9, 2024

View reviewed changes

sachinvodafone previously approved these changes Sep 10, 2024

View reviewed changes

Merge branch 'main' into jgarciahospital-patch-5

63a1c36

jgarciahospital dismissed stale reviews from sachinvodafone and hdamker via 63a1c36 September 10, 2024 09:39

jgarciahospital requested a review from sachinvodafone September 10, 2024 09:39

sachinvodafone previously approved these changes Sep 10, 2024

View reviewed changes

jgarciahospital dismissed sachinvodafone’s stale review via cd54e78 September 11, 2024 12:19

jgarciahospital added 3 commits September 11, 2024 14:19

Rename Population-Density-Data-API-Readiness-Checklist.md to populati…

cd54e78

…on-density-data-API-Readiness-Checklist.md

Merge branch 'main' into jgarciahospital-patch-5

d0de624

Update CHANGELOG.md

f65bd85

jgarciahospital requested review from hdamker, sachinvodafone, rartych, gregory1g, bigludo7 and a team September 11, 2024 12:26

hdamker previously approved these changes Sep 11, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

fc990bb

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

jgarciahospital dismissed hdamker’s stale review via fc990bb September 11, 2024 14:01

hdamker approved these changes Sep 11, 2024

View reviewed changes

bigludo7 approved these changes Sep 11, 2024

View reviewed changes

hdamker merged commit faae1ff into main Sep 11, 2024
1 check passed

hdamker deleted the jgarciahospital-patch-5 branch September 11, 2024 17:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare release r1.2 #45

Prepare release r1.2 #45

jgarciahospital commented Aug 23, 2024

hdamker left a comment

hdamker Aug 23, 2024

jgarciahospital Aug 24, 2024

hdamker Aug 23, 2024

jgarciahospital Aug 24, 2024

bigludo7 commented Sep 5, 2024

jgarciahospital commented Sep 5, 2024 •

edited

Loading

tanjadegroot commented Sep 6, 2024

jgarciahospital commented Sep 6, 2024

hdamker commented Sep 9, 2024 •

edited

Loading

hdamker left a comment •

edited

Loading

jgarciahospital commented Sep 11, 2024

bigludo7 left a comment

tanjadegroot commented Sep 11, 2024 •

edited

Loading

hdamker commented Sep 11, 2024

jgarciahospital commented Sep 11, 2024

tanjadegroot commented Sep 11, 2024

hdamker commented Sep 11, 2024

Prepare release r1.2 #45

Prepare release r1.2 #45

Conversation

jgarciahospital commented Aug 23, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewers:

hdamker left a comment

Choose a reason for hiding this comment

hdamker Aug 23, 2024

Choose a reason for hiding this comment

jgarciahospital Aug 24, 2024

Choose a reason for hiding this comment

hdamker Aug 23, 2024

Choose a reason for hiding this comment

jgarciahospital Aug 24, 2024

Choose a reason for hiding this comment

bigludo7 commented Sep 5, 2024

jgarciahospital commented Sep 5, 2024 • edited Loading

tanjadegroot commented Sep 6, 2024

jgarciahospital commented Sep 6, 2024

hdamker commented Sep 9, 2024 • edited Loading

hdamker left a comment • edited Loading

Choose a reason for hiding this comment

jgarciahospital commented Sep 11, 2024

bigludo7 left a comment

Choose a reason for hiding this comment

tanjadegroot commented Sep 11, 2024 • edited Loading

hdamker commented Sep 11, 2024

jgarciahospital commented Sep 11, 2024

tanjadegroot commented Sep 11, 2024

hdamker commented Sep 11, 2024

jgarciahospital commented Sep 5, 2024 •

edited

Loading

hdamker commented Sep 9, 2024 •

edited

Loading

hdamker left a comment •

edited

Loading

tanjadegroot commented Sep 11, 2024 •

edited

Loading