Align with Commonalities subscription-model by using sink and sinkCredentials #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on typos and including alignment of "$.sink" and "$.sinkCredentials" properties. Fixing small code and documentation typos and including alignment of "$.sink" and "$.sinkCredentials" properties.
jgarciahospital
requested review from
sachinvodafone and
maheshc01
as code owners
|
In my view it is not the subscription, but asynchronous response - therefore I opened the issue: camaraproject/Commonalities#297 |
rartych
approved these changes
Sep 5, 2024
bigludo7
reviewed
Sep 5, 2024
| code: "INVALID_ARGUMENT" | ||
| message: "Client specified an invalid argument, request body or query param" | ||
| code: 'INVALID_ARGUMENT' | ||
| message: 'Client specified an invalid argument, request body or query param' |
There was a problem hiding this comment.
What about adding also to be fully aligned with commonalities for the notification credential?
GENERIC_400_INVALID_PROTOCOL:
value:
status: 400
code: "INVALID_PROTOCOL"
message: "Only HTTP is supported"
GENERIC_400_INVALID_CREDENTIAL:
value:
status: 400
code: "INVALID_CREDENTIAL"
message: "Only Access token is supported"
GENERIC_400_INVALID_TOKEN:
value:
status: 400
code: "INVALID_TOKEN"
message: "Only bearer token is supported"`
There was a problem hiding this comment.
hope it's solved now, added (except Invalid_protocol, not sure where it comes from) and also added generic missing 410
|
Thanks, @bigludo7 . @sachinvodafone could you please validate for merging? |
sachinvodafone
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Fixing small code and documentation typos and including alignment of "$.sink" and "$.sinkCredentials" properties.
Which issue(s) this PR fixes:
Fixes #38