Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-correlator_support_guidelines_in_notifications #170

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

PedroDiez
Copy link
Collaborator

What type of PR is this?

  • enhancement
  • documentation

What this PR does / why we need it:

Clarified the support of "X-Correlator" in notification flows. Documenting it in:

  • API Design Guidelines
  • Cloud Event Artifact

Which issue(s) this PR fixes:

Fixes #164

Special notes for reviewers:

N/A

Changelog input

Clarified support of "X-Correlator" in notification flows

Additional documentation

N/A

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@bigludo7
Copy link
Collaborator

@rartych Probably this one can be merge wdyt?

@rartych
Copy link
Collaborator

rartych commented Apr 22, 2024

Yes, even in MoM there is decision to merge it.

@rartych rartych merged commit a7fa48d into main Apr 22, 2024
@rartych rartych deleted the x-correlator_support_guidelines_in_notifications branch October 9, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x-correlator in CloudsEvent notification?
5 participants