Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't log exception on missing bundle for base name messages #982

Merged
merged 1 commit into from
Aug 17, 2015
Merged

don't log exception on missing bundle for base name messages #982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vraptor-core/src/main/java/br/com/caelum/vraptor/core/JstlLocalization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ private ResourceBundle extractUnsafeBundle(Object bundle, Locale locale) {
try {
return ResourceBundle.getBundle(baseName, locale);
} catch (MissingResourceException e) {
logger.warn("couldn't find message bundle, creating an empty one", e);
logger.warn("couldn't find message bundle, creating an empty one");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add the baseName and locale on the message? It'd look like this:

couldn't find message bundle for base name messages, locale en_US. creating ...

return new EmptyBundle();
}
}
Expand Down