don't log exception on missing bundle for base name messages #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +77,7 @@ private ResourceBundle extractUnsafeBundle(Object bundle, Locale locale) { | |||
| try { | |||
| return ResourceBundle.getBundle(baseName, locale); | |||
| } catch (MissingResourceException e) { | |||
| logger.warn("couldn't find message bundle, creating an empty one", e); | |||
| logger.warn("couldn't find message bundle, creating an empty one"); | |||
There was a problem hiding this comment.
could you also add the baseName and locale on the message? It'd look like this:
couldn't find message bundle for base name messages, locale en_US. creating ...
|
It sounds great! Thanks for doing this, @fabriciofx. :) |
|
🚢 |
|
I'm merging here and opening an issue about baseName and locale on message |
Turini
added a commit
that referenced
this pull request
Aug 17, 2015
don't log exception on missing bundle for base name messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch do avoid log exception on missing bundle for base name messages.