Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 5916 interpreter wrong for vall true #6708

Merged
merged 19 commits into from
Jul 11, 2023
Merged

Fix 5916 interpreter wrong for vall true #6708

merged 19 commits into from
Jul 11, 2023

Commits on Jun 29, 2023

  1. Adding all missing branches to is_zero and adding cornercase to vall_… 

    …true tests
    @ms140569
    ms140569 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    f7ca505 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Starting to work on iterator

    @ms140569
    ms140569 committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    dde047d View commit details
    Browse the repository at this point in the history

  2. Move Iterator implementation to DataValueExt

    @ms140569
    ms140569 committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    1efc04b View commit details
    Browse the repository at this point in the history

  3. Backup commit

    @ms140569
    ms140569 committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ca7983b View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. quick and dirty iterator

    @ms140569
    ms140569 committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    93ed9c6 View commit details
    Browse the repository at this point in the history

  2. adding test

    @ms140569
    ms140569 committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3406115 View commit details
    Browse the repository at this point in the history

  3. Simplifying code. Adding tests

    @ms140569
    ms140569 committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3c51853 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. New implementation for Opcode::VallTrue

    @ms140569
    ms140569 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8205a8d View commit details
    Browse the repository at this point in the history

  2. Adding i64x2 testcase

    @ms140569
    ms140569 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c4bf758 View commit details
    Browse the repository at this point in the history

  3. Using try_fold makes the code way more readable

    @ms140569
    ms140569 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    08c80bd View commit details
    Browse the repository at this point in the history

  4. Correct results

    @ms140569
    ms140569 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    7695e7e View commit details
    Browse the repository at this point in the history

  5. Simplify code even more

    @ms140569
    ms140569 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a7e2730 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Merge branch 'bytecodealliance:main' into fix-5916-interpreter-wrong-… 

    …for-vall_true
    @ms140569
    ms140569 authored Jul 8, 2023
    Configuration menu
    Copy the full SHA
    2351514 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Fix typo and propagate error up the chain

    @ms140569
    ms140569 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    815c6b3 View commit details
    Browse the repository at this point in the history

  2. Simply clone() DataValue without going through integers

    @ms140569
    ms140569 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    1422505 View commit details
    Browse the repository at this point in the history

  3. Return InvalidType for is_zero on any vector

    @ms140569
    ms140569 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    0bd2552 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Handle V64 and V128 together 

    Co-authored-by: Afonso Bordado <afonso360@users.noreply.github.com>
    @ms140569 @afonso360
    ms140569 and afonso360 authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    8ea0036 View commit details
    Browse the repository at this point in the history

  2. Reformat code

    @ms140569
    ms140569 committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    9d29752 View commit details
    Browse the repository at this point in the history

  3. Reduce visibility of extractlanes

    @ms140569
    ms140569 committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d8d0e68 View commit details
    Browse the repository at this point in the history