Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 5916 interpreter wrong for vall true #6708

Merged
merged 19 commits into from
Jul 11, 2023
Merged

Fix 5916 interpreter wrong for vall true #6708

merged 19 commits into from
Jul 11, 2023

Conversation

ms140569
Copy link
Contributor

@ms140569 ms140569 commented Jul 8, 2023

This fixes: #5916

@ms140569 ms140569 requested a review from a team as a code owner July 8, 2023 10:29
@ms140569 ms140569 requested review from fitzgen and removed request for a team July 8, 2023 10:29
@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Jul 8, 2023
afonso360
afonso360 reviewed Jul 9, 2023
View reviewed changes
Copy link
Contributor

@afonso360 afonso360 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for working on this! 🎉 Just a few minor corrections.

And also thanks for adding in iter_lanes which is something I've been wanting to add for a while but haven't had time to do.

cranelift/interpreter/src/value.rs Outdated Show resolved Hide resolved
cranelift/interpreter/src/value.rs Outdated Show resolved Hide resolved
cranelift/interpreter/src/value.rs Outdated Show resolved Hide resolved
cranelift/interpreter/src/value.rs Outdated Show resolved Hide resolved
@afonso360 afonso360 removed the request for review from fitzgen July 9, 2023 13:15
afonso360
afonso360 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@afonso360 afonso360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but LGTM! 👍

cranelift/interpreter/src/value.rs Outdated Show resolved Hide resolved
ms140569 and others added 2 commits July 11, 2023 09:12
@ms140569 @afonso360
Handle V64 and V128 together
8ea0036 
Co-authored-by: Afonso Bordado <afonso360@users.noreply.github.com>
@ms140569
Reformat code
9d29752
@afonso360 afonso360 enabled auto-merge July 11, 2023 07:57
@afonso360 afonso360 added this pull request to the merge queue Jul 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 11, 2023
@afonso360 afonso360 added this pull request to the merge queue Jul 11, 2023
Merged via the queue into bytecodealliance:main with commit 731d9f1 Jul 11, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonso360 afonso360 afonso360 approved these changes

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cranelift: Interpreter returns the wrong result for vall_true.i8x16
2 participants
@ms140569 @afonso360