fuzzgen: Add SIMD instructions supported by the interpreter #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken in the interpreter bytecodealliance#5911
Broken in the interpreter bytecodealliance#5915
This is broken in the interpreter bytecodealliance#5916
Turns out it doesen't exist
github-actions
bot
added
the
cranelift
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "cranelift", "fuzzing"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
jameysharp
approved these changes
Mar 9, 2023
Co-Authored-By: Jamey Sharp <jsharp@fastly.com>
Co-Authored-By: Jamey Sharp <jsharp@fastly.com>
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Mar 13, 2023
…alliance#5971) * fuzzgen: Add some SIMD instructions * fuzzgen: Remove `scalar_to_vector` Broken in the interpreter bytecodealliance#5911 * fuzzgen: Remove SIMD bitcasts Broken in the interpreter bytecodealliance#5915 * fuzzgen: Fix insert lane * fuzzgen: Remove debug code * fuzzgen: Remove vall_true This is broken in the interpreter bytecodealliance#5916 * fuzzgen: Disable a few more ops * fuzzgen: Remove `iadd_pairwise.i64x2` Turns out it doesen't exist * fuzzgen: Remove scalar `sqmul_round_sat` bytecodealliance#5923 * fuzzgen: Disable aligned loads to SIMD values * fuzzgen: Address Review Feedback Co-Authored-By: Jamey Sharp <jsharp@fastly.com> * fuzzgen: Rework `cmp` exclusion rules Co-Authored-By: Jamey Sharp <jsharp@fastly.com> --------- Co-authored-by: Jamey Sharp <jsharp@fastly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR adds all SIMD instructions currently supported by the interpreter to the fuzzer. There is a surprising amount of missing coverage even with all of these ones (i.e. lots of work to do in the interpreter)!
I've also had to disable aligned loads/stores for > 8 bytes. It's really hard to do this without support from cranelift, and I think its probably best to go add support for that before re-enabling it here.
I gave this a bunch of fuzzing time, and it has stopped crashing on all arches. S390X was a little bit harder since I was only able to test it on QEMU and its quite a bit slower than native hardware though it ran about 12hours on 8 cores without crashing, so ¯\_(ツ)_/¯.