Fix: Cursor icon behavior in nested panels (#378) #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bvaughn
reviewed
Aug 20, 2024
| @@ -676,7 +676,7 @@ function PanelGroupWithForwardedRef({ | |||
| if (prevDeltaRef.current != delta) { | |||
| prevDeltaRef.current = delta; | |||
|
|
|||
| if (!layoutChanged) { | |||
| if (!layoutChanged && delta !== 0) { | |||
There was a problem hiding this comment.
How would this impact the else condition below?
There was a problem hiding this comment.
From what I understand if delta is 0 it always means that the mouse is on top of the resize handle, meaning it can't be outside of the resize limits, so constraint violations are set to none.
bvaughn
approved these changes
Aug 21, 2024
|
Thanks for the PR @catalinsh! Published in version 2.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the cursor icon in nested panels.
Tried in Windows 11 Chrome 127.0.6533.120