Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Cursor Icon Behavior in Nested Panels Example #378

Closed
benishouga opened this issue Jul 27, 2024 · 8 comments
Closed

Issue with Cursor Icon Behavior in Nested Panels Example #378

benishouga opened this issue Jul 27, 2024 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@benishouga
Copy link
Contributor

benishouga commented Jul 27, 2024

Issue with Cursor Icon Behavior in Nested Panels Example
Example Link: https://react-resizable-panels.vercel.app/examples/nested

Description:

I have noticed an issue with the cursor icon behavior in the nested panels example on your site.

  • Expected Behavior: When hovering over a PanelResizeHandle, the cursor icon should change to indicate the direction in which the panel can be resized.
  • Actual Behavior: After dragging vertically, when I try to drag a horizontally draggable PanelResizeHandle, the cursor icon still indicates vertical dragging instead of switching to horizontal dragging.

Steps to Reproduce:

  1. Go to the nested panels example.
  2. Drag a panel vertically.
  3. Hover over a horizontally draggable PanelResizeHandle.

Environment:

  • Windows 11 Home
  • Chrome 126.0.6478.185 (Official Build) (64-bit)

Visual Evidence:

I have prepared a video demonstrating this issue. Please review it for a better understanding.

examples_nested_icon_behavior.mp4

Thank you for looking into this issue.

@bvaughn
Copy link
Owner

bvaughn commented Jul 29, 2024

Hmm, this looks like maybe it could be related to pointer events in Chrome on Windows 11. (Like maybe there's an issue with the "pointerup" event or a ... no "pointermove" events afterward? Not sure.) Can't say I've seen this before, and I can't repro it on my end.

I'd be happy to review a PR if you have a change/proposal in mind.

@bvaughn bvaughn added the help wanted Extra attention is needed label Jul 29, 2024
@kaitoukid-1412
Copy link

kaitoukid-1412 commented Jul 31, 2024

Hi @bvaughn

I don't understand your project codebase so I can't PR. But I know how to fix it 🤡

image

image

4576d36#diff-e2e20e9a5e034afc8f1bf711478e920714b1a5a11163f5c4dae8cf83915848fb

https://www.npmjs.com/package/react-resizable-panels/v/2.0.21

@bvaughn
Copy link
Owner

bvaughn commented Jul 31, 2024

Not sure I understand, @kaitoukid-1412. Seems like you're suggesting a change that would potentially undo the fix for #340 though?

@kaitoukid-1412
Copy link

It's up to you @bvaughn , i'm not a professional!

@mohitsainiknl
Copy link

I'm facing the same problem. Any idea how to fix this?

@PabloCorso
Copy link

Would it possible to opt out the styling for the cursor? Aside from the current issue the styling seems like a sensible default, but in case of wanting to customise, the way styles are set makes it a bit hard to do it.

Thanks for the great library!

@bvaughn
Copy link
Owner

bvaughn commented Aug 15, 2024

Would it possible to opt out the styling for the cursor? Aside from the current issue the styling seems like a sensible default, but in case of wanting to customise, the way styles are set makes it a bit hard to do it.

Published in version 2.1.0


❤️ → ☕ givebrian.coffee

@bvaughn
Copy link
Owner

bvaughn commented Aug 21, 2024

Bugfix published in version 2.1.1


❤️ → ☕ givebrian.coffee

@bvaughn bvaughn closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants