Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make PanelOnResize arg prevMixedSizes optional #212

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

psychedelicious
Copy link
Contributor

@psychedelicious psychedelicious commented Nov 14, 2023

It is undefined on first render.

Closes #208
Context #209

FWIW, noUncheckedIndexedAccess in tsconfig would. have caught this, but it also catches a whole heck of a lot more.

It is `undefined` on first render.
Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 7:41pm

@bvaughn bvaughn merged commit 2b5318c into bvaughn:main Nov 14, 2023
7 checks passed
@bvaughn
Copy link
Owner

bvaughn commented Nov 14, 2023

Thanks!

FWIW, noUncheckedIndexedAccess in tsconfig would. have caught this, but it also catches a whole heck of a lot more.

Not apposed to making this change but probably don't have time/energy to do it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanelOnResize arg prevMixedSizes typed as required but is not present on init
2 participants