Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Panel): onResize missing prevMixedSizes on first render #209

Closed
wants to merge 2 commits into from
Closed

fix(Panel): onResize missing prevMixedSizes on first render #209

wants to merge 2 commits into from

Conversation

psychedelicious
Copy link
Contributor

Panel's onResize callback had prevMixedSizes undefined on first render.

  • Fall back to its mixedSizes when it is nullish
  • Add test for this case

Closes #208

@psychedelicious
fix(Panel): onResize missing prevMixedSizes on first render
4b9df53 
`Panel`'s `onResize` callback had `prevMixedSizes` undefined on first render.

- Fall back to its `mixedSizes` when it is nullish
- Add test for this case
@psychedelicious
fix(tests): fix typo in Panel.test.tsx
279038b 
"PanelGroup" -> "Panel"
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 5:38am

@psychedelicious
Copy link
Contributor Author

Why the test is failing a bit beyond me. I'm happy to try and fix it, but I'd need some direction. May not have really fixed the issue correctly of course.

@psychedelicious
Copy link
Contributor Author

Superseded by #212

@psychedelicious psychedelicious mentioned this pull request Nov 14, 2023
Merged
bvaughn pushed a commit that referenced this pull request Nov 14, 2023
@psychedelicious
fix: make PanelOnResize arg prevMixedSizes optional (#212)
2b5318c 
It is `undefined` on first render.

Closes #208 
Context #209

FWIW, `noUncheckedIndexedAccess` in tsconfig would. have caught this, but it also catches a whole heck of a lot more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PanelOnResize arg prevMixedSizes typed as required but is not present on init
2 participants
@psychedelicious @bvaughn