Add profiling option to track why a component rendered #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* User profiling setting * Background collects changed props/state (not added/removed or hooks yet) * Tests updated
bvaughn
changed the title
added 7 commits
June 8, 2019 09:10
bvaughn
commented
Jun 9, 2019
| @@ -350,7 +352,7 @@ export function attach( | |||
| // The unmount operations are already significantly smaller than mount opreations though. | |||
| // This is something to keep in mind for later. | |||
| function updateComponentFilters(componentFilters: Array<ComponentFilter>) { | |||
| if (this._isProfiling) { | |||
| if (isProfiling) { | |||
There was a problem hiding this comment.
This should not have slipped through before 😦
bvaughn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm exploring how the Profiler UI might help answer the question: Why did re-render?
New preference added
A component mounted
A component updated