Profiler shows which fibers scheduled an update, and why a given component rendered (do not merge) #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
force-pushed
the
scheduler-tracking
branch
3 times, most recently
from
bdfdfd9 to
864ae74
Compare
bvaughn
changed the title
This was referenced May 15, 2019
bvaughn
changed the title
bvaughn
force-pushed
the
scheduler-tracking
branch
from
ac7f6cf to
ed7a328
Compare
bvaughn
changed the title
bvaughn
commented
May 17, 2019
src/backend/renderer.js
Outdated
| @@ -1308,7 +1401,14 @@ export function attach( | |||
| timestamp: interaction.timestamp - profilingStartTime, | |||
| }) | |||
| ), | |||
| updaters: | |||
There was a problem hiding this comment.
Note to self: We should probably respect filtering preferences here. Otherwise we may end up showing "an unmounted component" when it was really just a filtered-out component.
bvaughn
changed the title
added 2 commits
May 20, 2019 10:00
bvaughn
force-pushed
the
scheduler-tracking
branch
from
b599adc to
2612b30
Compare
|
I'm going to split off the change tracking from the updater tracking, since the former is not blocked by a React PR. |
|
Closing all PRs at this repo as part of migrating to github.com/facebook/react |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR is blocked by React PR 15658 and unit tests are expected to fail unless using a version of React built from from the
scheduler-trackingbranch.I'm exploring how the Profiler UI might help answer a few common questions:
Why did this commit happen in the first place?
This feature requires a build of react-dom from the
scheduler-trackingbranch.Here's an example that shows how batched updates will list multiple schedulers:
And here's an example that illustrates both suspense (how the scheduler is continued across the ping) and how we could potentially handle a scheduler that is unmounted as a result of the udpate:
Why did component X re-render as part of it?
This is an example of how we could show what changed between renders:
Note that hooks are tricky to handle, so for now we don't try to display what hook changed.