Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to parent coords in tether-to-selection #141

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Fallback to parent coords in tether-to-selection #141

merged 1 commit into from
Oct 1, 2017

Commits on Sep 26, 2017

  1. Fallback to parent coords in tether-to-selection 

    A user reported that the link prompt was always offscreen. I traced this down to `range.getBoundingClient()` returning zero for dimensions and coords in certain cases—I was able to duplicate most reliably by opening a blank editor, hitting “enter”, hitting the “up” key, and finally hitting the link button.

Cases that trigger the issue seemed more prevalent in release Safari than in release Chrome for whatever reason. I could not find the root “cause” of the zeroed-out attributes, but found that falling back to `startContainer` works fine from a UI perspective.
    @dtetto
    dtetto committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    a4f4049 View commit details
    Browse the repository at this point in the history