Fallback to parent coords in tether-to-selection
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user reported that the link prompt was always offscreen. I traced this down to `range.getBoundingClient()` returning zero for dimensions and coords in certain cases—I was able to duplicate most reliably by opening a blank editor, hitting “enter”, hitting the “up” key, and finally hitting the link button. Cases that trigger the issue seemed more prevalent in release Safari than in release Chrome for whatever reason. I could not find the root “cause” of the zeroed-out attributes, but found that falling back to `startContainer` works fine from a UI perspective.
|
@dtetto This looks good to me. Thanks for tracking it down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported that the link prompt was always offscreen. I traced this down to
range.getBoundingClient()returning zero for dimensions and coords in certain cases—I was able to duplicate most reliably by opening a blank editor, hitting “enter”, hitting the “up” key, and finally hitting the link button.Cases that trigger the issue seemed more prevalent in release Safari than in release Chrome for whatever reason. I could not find the root “cause” of the zeroed-out attributes, but found that falling back to
startContainerworks fine from a UI perspective—so, admittedly, this is a case of treating the symptom…