Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform api changes to support phase 1 of Dockerfiles implementation #308

Merged
merged 14 commits into from
Aug 23, 2022

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Apr 15, 2022

Accompanies #307

platform.md Outdated Show resolved Hide resolved
Signed-off-by: Natalie Arellano <narellano@vmware.com>
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
Signed-off-by: Natalie Arellano <narellano@vmware.com>
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
@jromero
Copy link
Member

jromero commented Jun 15, 2022

@natalieparellano could we label what flags and executables will be gated behind an experimental flag?

@natalieparellano
Copy link
Member Author

Thanks for the review @jromero. I need to update this PR a bit with the learnings from the implementation (1, 2). I'll write back when that's completed.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested a review from a team as a code owner June 15, 2022 21:14
Signed-off-by: Natalie Arellano <narellano@vmware.com>
platform.md Outdated Show resolved Hide resolved
@natalieparellano natalieparellano self-assigned this Jun 16, 2022
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@jromero jromero self-requested a review June 24, 2022 19:42
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano added this to the Platform 0.10 milestone Jun 29, 2022
The 80 range is for the launcher.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
Co-authored-by: Javier Romero <rjavier@vmware.com>

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Javier Romero <rjavier@vmware.com>

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Javier Romero <rjavier@vmware.com>

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
platform.md Outdated Show resolved Hide resolved
@jromero jromero self-requested a review August 3, 2022 19:45
platform.md Outdated Show resolved Hide resolved
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Copy link
Member

@jromero jromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well-done

@natalieparellano
Copy link
Member Author

Accidentally merged into main, not platform/0.10. Will create a new PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants