Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildpack api changes to support phase 1 of Dockerfiles implementation #307

Merged
merged 11 commits into from
Aug 23, 2022

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Apr 15, 2022

This would allow extensions to output a Dockerfile that can be used to switch the runtime base image only.

The extension phase is not needed as nothing is applied.

For further context, see this comment.

buildpack.md Outdated Show resolved Hide resolved
buildpack.md Outdated Show resolved Hide resolved
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano and others added 2 commits June 15, 2022 17:27
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: BarDweller <bardweller@gmail.com>
cache svgs and set svg bg to white (helps with github darkmode)
buildpack.md Outdated Show resolved Hide resolved
buildpack.md Outdated Show resolved Hide resolved
image_extension.md Outdated Show resolved Hide resolved
image_extension.md Outdated Show resolved Hide resolved
Copy link
Member

@jkutner jkutner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple small questions about word choice

@natalieparellano
Copy link
Member Author

Thanks @jkutner! I made some updates based on your feedback.

buildpack.md Outdated Show resolved Hide resolved
buildpack.md Outdated Show resolved Hide resolved
@natalieparellano
Copy link
Member Author

natalieparellano commented Jun 27, 2022

I rebased this onto #300 (since they are so interdependent, maybe it makes sense). But I can also put it back if that's easier to review.

It's probably better to merge #300 first so that the diff is easier to parse.

Also make clear that generation is for extensions and build is for buildpacks

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano changed the base branch from buildpack/0.9 to buildpack-terminology June 27, 2022 19:39
@natalieparellano natalieparellano added this to the Buildpack 0.9 milestone Jun 29, 2022
A couple other small fixes.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Base automatically changed from buildpack-terminology to buildpack/0.9 August 23, 2022 08:53
@sambhav sambhav merged commit be79544 into buildpack/0.9 Aug 23, 2022
@sambhav sambhav deleted the extensions-buildpack-api branch August 23, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants