Fixes from security review #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://github.com/buildpacks/pack-private/issues/26 Signed-off-by: Natalie Arellano <narellano@vmware.com>
Fixes https://github.com/buildpacks/pack-private/issues/21 Signed-off-by: Natalie Arellano <narellano@vmware.com>
Fixes https://github.com/buildpacks/pack-private/issues/20 Signed-off-by: Natalie Arellano <narellano@vmware.com>
…exclude inline buildpacks) Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
…=true Fixes https://github.com/buildpacks/pack-private/issues/22 Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
… unit tests Signed-off-by: Natalie Arellano <narellano@vmware.com>
Run build containers with updated settings
Use the untrusted flow when buildpacks are added to a trusted builder
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Ensure that the user has not requested to build an image with the same name as a builder of a lifecyle image. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net> Signed-off-by: Aidan Delaney <aidan.delaney@gmail.com> Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
…emon Validate image name
Warn if NOT --pull-policy=always in container
Launch build containers in a separate ephemeral Docker bridge network
…ontainer Signed-off-by: Natalie Arellano <narellano@vmware.com>
When creating volume caches, incorporate "pack volume key" to avoid name collisions
github-actions
bot
added
type/enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
==========================================
- Coverage 70.13% 70.02% -0.11%
==========================================
Files 254 254
Lines 18489 18667 +178
==========================================
+ Hits 12966 13070 +104
- Misses 4675 4730 +55
- Partials 848 867 +19
Flags with carried forward coverage won't be shown. Click here to find out more. |
jjbustamante
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2216
Output
Before
After
Documentation
Related
Resolves #___