Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some comments #1734

Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix some comments #1734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/delivery-ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
UBUNTU_VERSION: ${{ matrix.target }}

###
# NOTE: 'uses' does not suport interpolation so we have to manually define the
# NOTE: 'uses' does not support interpolation so we have to manually define the
# following steps per variant.
###

Expand Down
2 changes: 1 addition & 1 deletion internal/commands/buildpack_inspect_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ func testBuildpackInspectCommand(t *testing.T, when spec.G, it spec.S) {
})
})

when("uri is a http or https location", func() {
when("uri is an http or https location", func() {
it.Before(func() {
simpleInfo.Location = buildpack.URILocator
})
Expand Down
2 changes: 1 addition & 1 deletion internal/commands/inspect_buildpack_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ func testInspectBuildpackCommand(t *testing.T, when spec.G, it spec.S) {
assert.TrimmedEq(outBuf.String(), expectedOutput)
})
})
when("uri is a http or https location", func() {
when("uri is an http or https location", func() {
it.Before(func() {
simpleInfo.Location = buildpack.URILocator
})
Expand Down
2 changes: 1 addition & 1 deletion pkg/archive/archive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func GenerateTar(genFn func(TarWriter) error) io.ReadCloser {
return GenerateTarWithWriter(genFn, DefaultTarWriterFactory())
}

// GenerateTarWithTar returns a reader to a tar from a generator function using a writer from the provided factory.
// GenerateTarWithWriter returns a reader to a tar from a generator function using a writer from the provided factory.
// Note that the generator will not fully execute until the reader is fully read from. Any errors returned by the
// generator will be returned when reading the reader.
func GenerateTarWithWriter(genFn func(TarWriter) error, twf TarWriterFactory) io.ReadCloser {
Expand Down
2 changes: 1 addition & 1 deletion pkg/client/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ type BuildOptions struct {
DockerHost string

// Used to determine a run-image mirror if Run Image is empty.
// Used in combination with Builder metadata to determine to the the 'best' mirror.
// Used in combination with Builder metadata to determine to the 'best' mirror.
// 'best' is defined as:
// - if Publish is true, the best mirror matches registry we are publishing to.
// - if Publish is false, the best mirror matches a registry specified in Image.
Expand Down
2 changes: 1 addition & 1 deletion pkg/client/build_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,7 +1202,7 @@ func testBuild(t *testing.T, when spec.G, it spec.S) {
})
})

when("uri is a http url", func() {
when("uri is an http url", func() {
var server *ghttp.Server

it.Before(func() {
Expand Down