Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some comments #1734

Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix some comments #1734

merged 1 commit into from
Apr 27, 2023

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Apr 25, 2023 •
edited
Loading

Summary

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

@cuishuang
fix some comments
31224ea 
Signed-off-by: cui fliter <imcusg@gmail.com>
@cuishuang cuishuang requested review from a team as code owners April 25, 2023 07:01
@github-actions github-actions bot added this to the 0.30.0 milestone Apr 25, 2023
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Apr 25, 2023
natalieparellano
natalieparellano approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @cuishuang!

@jkutner jkutner merged commit 5e5a437 into buildpacks:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalieparellano natalieparellano natalieparellano approved these changes

@jkutner jkutner jkutner approved these changes

Assignees
No one assigned
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cuishuang @jkutner @natalieparellano