Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Switch back to Bazel 7.4.0" #8292

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Revert "Switch back to Bazel 7.4.0" #8292

merged 2 commits into from
Feb 3, 2025

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Feb 3, 2025

Reverts #8290, reland of #8076 and #8266

Also patch rules_docker to not use struct.to_json().

@fmeum fmeum requested a review from iain-macdonald February 3, 2025 19:58
iain-macdonald
iain-macdonald approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@iain-macdonald iain-macdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@fmeum fmeum merged commit fae4e1e into master Feb 3, 2025
16 checks passed
@fmeum fmeum deleted the revert-8290-backtobazel7 branch February 3, 2025 21:52
vadimberezniker added a commit that referenced this pull request Feb 4, 2025
@vadimberezniker
Revert "Revert "Switch back to Bazel 7.4.0" (#8292)"
82b3abc 
This reverts commit fae4e1e.
@vadimberezniker vadimberezniker mentioned this pull request Feb 4, 2025
Merged
vadimberezniker added a commit that referenced this pull request Feb 4, 2025
@vadimberezniker
Revert bazel 8 upgrade (#8299)
3b0463a 
Reverts #8292

Breaks rules_k8s:
```
	File "/home/vadim/.cache/bazel/_bazel_vadim/6f184f57ee0ec63880c4d01d291bbab7/external/io_bazel_rules_k8s/k8s/object.bzl", line 125, column 10, in _impl
		).to_json(),
Error: 'struct' value has no field or method 'to_json'
```

cc @fmeum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iain-macdonald iain-macdonald iain-macdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @iain-macdonald