Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: Update to Bazel 8.0.1 #8076

Merged
merged 1 commit into from
Jan 29, 2025
Merged

bazel: Update to Bazel 8.0.1 #8076

merged 1 commit into from
Jan 29, 2025

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Dec 18, 2024

No description provided.

@fmeum
Copy link
Contributor Author

fmeum commented Dec 18, 2024

FYI @sluongng in case you are also looking into this at some point

@fmeum fmeum force-pushed the bazel-8 branch 2 times, most recently from 8f19c1b to 0260e88 Compare January 17, 2025 07:29
@fmeum
Copy link
Contributor Author

fmeum commented Jan 17, 2025

Stacked on #8204

@sluongng
Copy link
Contributor

I think this should be ready now?

@fmeum fmeum changed the title bazel: Update to Bazel 8 bazel: Update to Bazel 8.0.1 Jan 24, 2025
@fmeum fmeum marked this pull request as ready for review January 24, 2025 14:26
@fmeum fmeum requested a review from sluongng January 24, 2025 14:26
@fmeum fmeum enabled auto-merge (squash) January 24, 2025 17:42
@fmeum fmeum disabled auto-merge January 24, 2025 18:29
@fmeum fmeum enabled auto-merge (squash) January 24, 2025 18:29
@fmeum
Copy link
Contributor Author

fmeum commented Jan 24, 2025

Ready now with tests passing

Copy link
Contributor

@sluongng sluongng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tiny nits but LGTM

.bazelrc Show resolved Hide resolved
Comment on lines +120 to +122
integrity = "sha256-YMGrS+/p0Kl1wjRLVRG/a0T5HsPhQmyHj1a/MKBYnEM=",
strip_prefix = "protobuf-29.2",
urls = ["https://github.com/protocolbuffers/protobuf/releases/download/v29.2/protobuf-29.2.zip"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Let's not downgrade this. Use the current version or upgrade to the latest.

WORKSPACE.bzlmod Show resolved Hide resolved
@fmeum fmeum merged commit 1ea92ac into master Jan 29, 2025
16 checks passed
@fmeum fmeum deleted the bazel-8 branch January 29, 2025 17:05
iain-macdonald added a commit that referenced this pull request Feb 3, 2025
iain-macdonald added a commit that referenced this pull request Feb 3, 2025
fmeum added a commit that referenced this pull request Feb 3, 2025
Reverts #8290, reland of #8076 and #8266 

Also patch rules_docker to not use `struct.to_json()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants