Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v6.21.0 #667

Merged
merged 27 commits into from
Jun 23, 2021
Merged

Release v6.21.0 #667

merged 27 commits into from
Jun 23, 2021

Conversation

imjoehaines
Copy link
Contributor

Enhancements

  • Allow a Method or any object responding to #call to be used as an on_error callback or middleware
    | #662
    | odlp

Fixes

  • Deliver when an error is raised in the block argument to notify
    | #660
    | aki77
  • Fix potential NoMethodError in Bugsnag::Railtie when using require: false in a Gemfile
    | #666

twometresteve and others added 27 commits April 14, 2021 21:42
This is consistent with how we report errors in other places, e.g.
middleware and on_error callbacks
ExecJS doesn't support therubyracer anymore so the delayed_job app
doesn't run
Deliver even when an error raised in the block argument
Allow Methods to be used as callbacks/middleware
This can happen if Bugsnag is added to the Gemfile with 'require: false'.
In this case, 'require "bugsnag"' in a Rails initializer will run the
'config.before_initialize' before the rest of the Railtie has been
executed. This results in the 'event_subscription' method being
undefined as it was declared below the line that calls it

By moving it to the top of the file this is no longer a problem
@imjoehaines imjoehaines merged commit 561bba4 into master Jun 23, 2021
@imjoehaines imjoehaines deleted the release/v6.21.0 branch June 23, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants