Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver even when an error raised in the block argument #664

Merged
merged 6 commits into from
Jun 17, 2021
Merged

Conversation

imjoehaines
Copy link
Contributor

Goal

This is #660 with next merged and the implementation tweaked to log a message instead of adding metadata, so it's consistent with how we handle errors in other places — e.g. in on_error callbacks:

begin
should_continue = callback.call(report)
rescue StandardError => e
Bugsnag.configuration.warn("Error occurred in on_error callback: '#{e}'")
Bugsnag.configuration.warn("on_error callback stacktrace: #{e.backtrace.inspect}")
end

@imjoehaines imjoehaines merged commit 46aa29a into next Jun 17, 2021
@imjoehaines imjoehaines deleted the fix-notify branch June 17, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants