Release v6.19.0 #651
Merged
Release v6.19.0 #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exception occurs, such as a `Mysql2::Error::ConnectionError`, where the query is extremely long, this can cause the payload to exceed what Bugsnag will accept and throw a `Errno::EPIPE: Broken pipe` error when trying to send the request to Bugsnag. A number of elements are already trimmed when the payload is too large, including meta data, stacktrace code, etc. However, the exception messages were not being trimmed. This commit adds exception message trimming to `Bugsnag::Helpers.trim_if_needed`, which should help reduce errors when the queries causing the errors are exceptionally long. It also adds a spec to `helper_spec.rb` that tests this functionality.
Loosen restriction on Delayed Job version in MR tests
Use up-to-date Bundler versions
Truncate Exception Messages if needed
This existed due to constraints that no longer exist — it's now valid to have any value in metadata
…ation Remove breadcrumb metadata validation
On Ruby 3 we currently get 1.6.0 because 1.7.0 added a Ruby version constraint that requires Ruby 2 Only 1.8.0 actually works on Ruby 3, but this still has the version constraint that stops it from being installed Until 1.9.0 is released, we have to use the (currently) latest commit on master, which loosens the Ruby version constraing and allows it to be installed on Ruby 3 The root problem is the keyword hash argument changes in Ruby 3 which older versions of redis-namespace are not compatible with
This fixes a Errno::ECONNREFUSED error which happens commonly, but not every time. The notifier request still fires so the test passes, but some change in Ruby 3 doesn't like that the application immediately crashes
Crack 0.4.5 requires REXML as a dependency. There's no published REXML version that works on 1.9, so we have to restrict the Crack version instead
Add Ruby 3.0 to CI
This doesn't seem to flake on CI (at least I haven't noticed it) but it failed pretty commonly locally before this change
Fix Que & Mailman test fixtures on Ruby 2.0
Test on Sidekiq 6
kattrali
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.19.0 (6 January 2021)
Enhancements
Exception messages will be truncated if they have a length greater than 3,072
| #636
| joshuapinter
Breadcrumb metadata can now contain any type
| #648