Truncate Exception Messages if needed #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exception occurs, such as a `Mysql2::Error::ConnectionError`, where the query is extremely long, this can cause the payload to exceed what Bugsnag will accept and throw a `Errno::EPIPE: Broken pipe` error when trying to send the request to Bugsnag. A number of elements are already trimmed when the payload is too large, including meta data, stacktrace code, etc. However, the exception messages were not being trimmed. This commit adds exception message trimming to `Bugsnag::Helpers.trim_if_needed`, which should help reduce errors when the queries causing the errors are exceptionally long. It also adds a spec to `helper_spec.rb` that tests this functionality.
kattrali
reviewed
Dec 21, 2020
kattrali
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR #636 rebased onto
next+ a changelog entryGoal
If an exception occurs, such as a
Mysql2::Error::ConnectionError, where the query is extremely long, this can cause the payload to exceed what Bugsnag will accept and throw aErrno::EPIPE: Broken pipeerror when trying to send the request to Bugsnag.A number of elements are already trimmed when the payload is too large, including meta data, stacktrace code, etc. However, the exception messages were not being trimmed.
This commit adds exception message trimming to
Bugsnag::Helpers.trim_if_needed, which should help reduce errors when the queries causing the errors are exceptionally long.Design
A number of elements are already trimmed when the payload is too large, including meta data, stacktrace code, etc. However, the exception messages were not being trimmed.
This commit adds exception message trimming to
Bugsnag::Helpers.trim_if_needed, which should help reduce errors when the queries causing the errors are exceptionally long.Changeset
Added
truncate_exception_messagestoBugsnag::Helpers.trim_if_neededmethod, which truncates the exception messages if necessary.Testing
Manually on our Rails 4.2 / Bugsnag 6.17.0 enterprise application.
Added a spec to
helper_spec.rbthat tests this functionality specifically.✅ All tests passing when running
bundle exec rake.