Move the Sidekiq reporter to after the logging middleware #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Server::Logging middleware is the outermost middleware that Sidekiq provides by default. This is a very safe place to put error reporting middleware, because any custom code implemented by users of Bugsnag will probably not cause erroneous reports.
|
Looks like travis had a hiccup? |
reubenbrown
added a commit
to reubenbrown/bugsnag-ruby
that referenced
this pull request
Apr 25, 2017
…gsnag#326)" This reverts commit c7862ea. Fixes bugsnag#357
kattrali
pushed a commit
that referenced
this pull request
Apr 27, 2017
kattrali
pushed a commit
that referenced
this pull request
Oct 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Server::Logging middleware is the outermost middleware that Sidekiq provides by default.
This is a very safe place to put error reporting middleware, because any custom code implemented
by users of Bugsnag will probably not cause erroneous reports.
Specifically, we use a class that prevents error logging for certain error types
Sidekiq::Retryunless it's the final retry. This helps reduce noise greatly. Bugsnag will report these errors even if we catch them ourselves, because it runs before our middleware. However, this middleware must execute after RetryJobs middleware.We have a fix for this in our code (manually removing / adding Bugsnag back in), but wanted to also provide this insight for the Bugsnag team.