Skip to content

Commit

Permalink
Revert "Move the Sidekiq reporter to after the logging middleware (#326…
Browse files Browse the repository at this point in the history 
…)"

This reverts commit c7862ea.

Fixes #357
Closes #358
  • Loading branch information
@reubenbrown @kattrali
reubenbrown authored and kattrali committed Apr 27, 2017
1 parent 7531b8a commit 9c75368
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/bugsnag/sidekiq.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ def call(worker, msg, queue)

::Sidekiq.configure_server do |config|
config.server_middleware do |chain|
chain.insert_after ::Sidekiq::Middleware::Server::Logging, ::Bugsnag::Sidekiq
if Gem::Version.new(Sidekiq::VERSION) >= Gem::Version.new('3.3.0')
chain.prepend ::Bugsnag::Sidekiq
else
chain.add ::Bugsnag::Sidekiq
end
end
end

2 comments on commit 9c75368

@tpal94
Copy link

@tpal94 tpal94 commented on 9c75368 Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have not added the Sidekiq::Middleware::Server::Logging Middleware so I think there might be the problem with logging

@kattrali
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

::Sidekiq::Middleware::Server::Logging should exist in the user's configuration if they are using sidekiq middleware, and not be something that Bugsnag adds. Are you experiencing an issue with this, @tpal94?

Please sign in to comment.