This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
style(js): Add standardjs linter #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jekiwijaya
pushed a commit
to Jekiwijaya/bugsnag-react-native
that referenced
this pull request
Mar 11, 2019
Session tracking amends
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of a linter, coupled with tests not covering all branches of the JS, allowed #217 to
happen. This adds linting to the CI job, and if the relevant editor plugins are installed shows lint
errors inside the editor.
Closes #217.
The standardjs linter is used on our js notifier, so I think it makes sense for consistency to use the same one here.
Most of the lint issues were fixed easily using
standard --fixbut there were a couple of places where "unidiomatic" JS was used, and these were swapped for expressions that made the linter happy… e.g.null/undefinedcheck:value != undefined->[ null, undefined ].includes(value)