Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Fix missing variable declaration #217

Closed
wants to merge 1 commit into from
Closed

Fix missing variable declaration #217

wants to merge 1 commit into from

Conversation

jamesreggio
Copy link
Contributor

Unfortunately, the lack of declaration was causing a crash in the notify function when I had a beforeSendCallback installed.

Perhaps you could setup a linter to catch some of these issues?

bengourley added a commit that referenced this pull request Mar 13, 2018
@bengourley
style(js): Add standardjs linter
c8ccc6f 
The lack of a linter, coupled with tests not covering all branches of the JS, allowed #217 to
happen. This adds linting to the CI job, and if the relevant editor plugins are installed shows lint
errors inside the editor.

Closes #217.
@bengourley bengourley mentioned this pull request Mar 13, 2018
Merged
kattrali pushed a commit that referenced this pull request Mar 14, 2018
@bengourley @kattrali
style(js): Add standardjs linter (#223)
d4eccdd 
The lack of a linter, coupled with tests not covering all branches of the JS, allowed #217 to
happen. This adds linting to the CI job, and if the relevant editor plugins are installed shows lint
errors inside the editor.

Closes #217.
@jamesreggio jamesreggio deleted the fix-block-scope branch July 6, 2018 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesreggio