Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Allow Bugsnag's breadcrumb logger to be turned off (Android) #245

Closed
cpetzel opened this issue Jun 1, 2018 · 2 comments
Closed

Allow Bugsnag's breadcrumb logger to be turned off (Android) #245

cpetzel opened this issue Jun 1, 2018 · 2 comments
Labels
scheduled Work is starting on this feature/bug

Comments

@cpetzel
Copy link
Contributor

cpetzel commented Jun 1, 2018

Description

Superfluous logging output with breadcrumbs.

Issue

The Bugsnag SDK outputs the breadcrumbs to Logcat before it saves the breadcrumb. This is flooding our console (and other log capturing SDK's ) with a ton of erroneous log statements.

https://github.com/bugsnag/bugsnag-react-native/blob/master/android/src/main/java/com/bugsnag/BugsnagReactNative.java#L92

You should expose an API to disable this logger.

Environment

Library versions: react native bugsnag v 2.9.3

@kattrali
Copy link
Contributor

kattrali commented Jun 1, 2018

Thanks for the report, @cpetzel. At most that should be a debug log instead of info.

@kattrali kattrali added the scheduled Work is starting on this feature/bug label Jun 1, 2018
kattrali added a commit that referenced this issue Jun 1, 2018
kattrali added a commit that referenced this issue Jun 1, 2018
kattrali added a commit that referenced this issue Jun 1, 2018
@cpetzel
Copy link
Contributor Author

cpetzel commented Jun 1, 2018

Thank you for the quick response :)

Jekiwijaya pushed a commit to Jekiwijaya/bugsnag-react-native that referenced this issue Mar 11, 2019
Error class and message are not being set for errors when thread tracing
is disabled leading to the error class being set to the default "Exception"
and error message being empty. This change ensures that error class
and message are set regardless of the setting.
 
Fixes regression introduced in f62ca6e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scheduled Work is starting on this feature/bug
Projects
None yet
Development

No branches or pull requests

2 participants