Reduce gratuitous logging

Fixes #245
bugsnag · Jun 1, 2018 · 934c733 · 934c733
1 parent 741dcca
commit 934c733
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,13 @@
 Changelog
 =========
 
+## TBD
+
+### Bug fixes
+
+* (android) Reduce gratutious android logging
+  [#245](https://github.com/bugsnag/bugsnag-react-native/issues/245)
+
 ## 2.9.4 (2018-05-02)
 
 * Enable nativeSerializer to handle Error objects by extracting the stack and message from a given Error class before serialising it. [#239](https://github.com/bugsnag/bugsnag-react-native/issues/239) [#240](https://github.com/bugsnag/bugsnag-react-native/pull/240) [daisy1754](https://github.com/daisy1754) [Cawllec](https://github.com/Cawllec)

diff --git a/Makefile b/Makefile
@@ -39,6 +39,6 @@ ifeq ($(IOS_VERSION),)
 endif
 	@git -C ../bugsnag-cocoa fetch
 	@git -C ../bugsnag-cocoa checkout v$(IOS_VERSION)
-	@rsync --delete -al ../bugsnag-cocoa/Source cocoa/vendor/bugsnag-cocoa/Source
-	@rsync --delete -al ../bugsnag-cocoa/iOS cocoa/vendor/bugsnag-cocoa/iOS
+	@rsync --delete -al ../bugsnag-cocoa/Source/ cocoa/vendor/bugsnag-cocoa/Source/
+	@rsync --delete -al ../bugsnag-cocoa/iOS/ cocoa/vendor/bugsnag-cocoa/iOS/
 	@git status
diff --git a/android/src/main/java/com/bugsnag/BugsnagReactNative.java b/android/src/main/java/com/bugsnag/BugsnagReactNative.java
@@ -89,7 +89,6 @@ public void startWithOptions(ReadableMap options) {
   @ReactMethod
   public void leaveBreadcrumb(ReadableMap options) {
       String name = options.getString("name");
-      logger.info(String.format("Leaving breadcrumb '%s'", name));
       Bugsnag.leaveBreadcrumb(name,
                               parseBreadcrumbType(options.getString("type")),
                               readStringMap(options.getMap("metadata")));
@@ -130,18 +129,16 @@ public void notifyBlocking(ReadableMap payload, boolean blocking, com.facebook.r
       map.put("severity", severity);
       map.put("severityReason", severityReason);
 
-      logger.info("Notifying native client, severity = " + severity +
+      logger.debug("Notifying native client, severity = " + severity +
               ", severityReason = " + severityReason);
       Bugsnag.internalClientNotify(exc, map, blocking, handler);
-      logger.info("Notified native client");
 
       if (callback != null)
         callback.invoke();
   }
 
   @ReactMethod
   public void setUser(ReadableMap userInfo) {
-      logger.info("Setting user data");
       String userId = userInfo.hasKey("id") ? userInfo.getString("id") : null;
       String email = userInfo.hasKey("email") ? userInfo.getString("email") : null;
       String name = userInfo.hasKey("name") ? userInfo.getString("name") : null;
@@ -406,7 +403,6 @@ class JavaScriptException extends Exception implements JsonStream.Streamable {
     }
 
     public void toStream(JsonStream writer) throws IOException {
-        BugsnagReactNative.logger.info("Serializing exception");
         writer.beginObject();
         writer.name("errorClass").value(name);
         writer.name("message").value(getLocalizedMessage());