Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve normaliseError() utility in Client class #516

Merged
merged 9 commits into from
Apr 9, 2019
Merged

Improve normaliseError() utility in Client class #516

merged 9 commits into from
Apr 9, 2019

Commits on Apr 4, 2019

  1. fix(core): Ensure usage errors are reported correctly 

    The existing logic prevented "null" from being reported correctly. This cleans up the logic and
makes sure it's all contained in the normaliseError() function.

Fixes #400.
    @bengourley
    bengourley committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    a1d3993 View commit details
    Browse the repository at this point in the history

  2. fix(core): Ensure generated stacktraces don't contain bugsnag library… 

    … frames

When the change in dd4030b was applied, this should have happened but there were no tests verifying
this aspect of the notifier so the regression was not picked up. This update adds some unit and
end-to-end tests for this particular code path.
    @bengourley
    bengourley committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    40a354c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. refactor(core): Use const for the number of synthesized frames to skip

    @bengourley
    bengourley committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    d3134ae View commit details
    Browse the repository at this point in the history

  2. fix(core): Also skip correct number of frames for generated stacktraces

    @bengourley
    bengourley committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    ffa096a View commit details
    Browse the repository at this point in the history

  3. test(core): Not all browsers have "stackframe.file", assert number of… 

    … frames instead
    @bengourley
    bengourley committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    b51583e View commit details
    Browse the repository at this point in the history

  4. test(core): Number of frames can be different but first should be cor… 

    …rect
    @bengourley
    bengourley committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    7e77b62 View commit details
    Browse the repository at this point in the history

  5. test(node): Add node end-to-end test for synthesized error frames

    @bengourley
    bengourley committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    3412d4e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'next' into client-normalise-err-improvements

    @bengourley
    bengourley committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    dbe81d9 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'next' into client-normalise-err-improvements

    @bengourley
    bengourley committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    ceb2e19 View commit details
    Browse the repository at this point in the history