Improve normaliseError() utility in Client class #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic prevented "null" from being reported correctly. This cleans up the logic and makes sure it's all contained in the normaliseError() function. Fixes #400.
… frames When the change in dd4030b was applied, this should have happened but there were no tests verifying this aspect of the notifier so the regression was not picked up. This update adds some unit and end-to-end tests for this particular code path.
snmaynard
reviewed
Apr 4, 2019
kattrali
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of improvements to the
normaliseError()function which is used bynotify()to coerce its arguments into a reasonable error, or generate an error alerting the developer to incorrect usage:notify()call that ended up generating a stacktrace included a frame from this codebase. TheerrorFramesToSkipcount has been bump to mitigate that.nullended up in the "object" case block (see Generate a correct error message when null is passed to notify() #400 for original report/potential fix)Testing
Unit tests and end-to-end tests added to cover these changes.
Bundle size discussion time
Since this makes changes to
@bugsnag/coreit stands to affect browser bundle size. Here's the change:Net decrease of
0.04kB. I think this is 🆒.