Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set appActivity and appPackage Appium capabilities to avoid RN test flakes #2065

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

twometresteve
Copy link
Contributor

@twometresteve twometresteve commented Jan 9, 2024

Goal

Set appActivity and appPackage Appium capabilities, using Maze Runner options, to avoid test flakes when trying to start the Android React Native test fixtures.

Design

The main change here should resolve a common test failure when starting Android apps with Appium 2. After making the initial change, there was some confusion resulting from each test fixture having a difference package name. So I've also taken the opportunity to make them all consistent, as com.reactnative.

Changeset

The number of changed files looks unwieldy, but it's the same set of simple changes made many times.

A number of files in the diff are showing as deleted and created, but all I've done is change their package, resulting in a file move that GitHub somehow hasn't recognised.

Testing

Covered by a full CI run.

Copy link

github-actions bot commented Jan 9, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.67 kB 13.40 kB
After 43.67 kB 13.40 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 11ed5c7

Copy link
Contributor

@Cawllec Cawllec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twometresteve twometresteve merged commit 935b1a4 into next Jan 9, 2024
158 checks passed
@twometresteve twometresteve deleted the tms/cannot-start-app-2 branch January 9, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants