Skip to content

Commit

Permalink
Corrections
Browse files Browse the repository at this point in the history
[full ci]
  • Loading branch information
twometresteve committed Jan 9, 2024
1 parent 9dda839 commit 11ed5c7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .buildkite/full/react-native-cli-pipeline.full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -687,8 +687,8 @@ steps:
service-ports: true
command:
- --app=build/rn0_63_expo_ejected.apk
- --app-activity=com.reactnative_expo_ejected.MainActivity
- --app-package=com.reactnative_expo_ejected
- --app-activity=com.reactnative.MainActivity
- --app-package=com.reactnative
- --farm=bb
- --device=ANDROID_10|ANDROID_11|ANDROID_12
- --a11y-locator
Expand Down
2 changes: 1 addition & 1 deletion scripts/react-native-cli-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ module.exports = {
common.run(initCommand, true)

// Use Perl to replace the Bugsnag start command to use a loaded configuration
const applicationPath = `android/app/src/main/java/com/${rnVersion}/`
const applicationPath = 'android/app/src/main/java/com/reactnative/'
common.changeDir(`${destFixtures}/${rnVersion}/${applicationPath}`)
const perlCommand = 'perl -pi -e "s/Bugsnag.start\\(this\\);/Bugsnag.start\\(this, createConfiguration\\(\\)\\);/g" MainApplication.java'
common.run(perlCommand, true)
Expand Down
10 changes: 5 additions & 5 deletions test/react-native-cli/features/steps/steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,12 @@ def parse_package_json
step("the interactive file '#{filename}' contains '[Bugsnag start];'")
end

def get_android_main_application_path(current_fixture)
"android/app/src/main/java/com/#{current_fixture}/MainApplication.java"
def get_android_main_application_path
"android/app/src/main/java/com/reactnative/MainApplication.java"
end

Then('the Android app contains the bugsnag initialisation code') do
filename = get_android_main_application_path current_fixture
filename = get_android_main_application_path
step("the interactive file '#{filename}' contains 'import com.bugsnag.android.Bugsnag;'")
step("the interactive file '#{filename}' contains 'Bugsnag.start(this);'")
end
Expand All @@ -242,7 +242,7 @@ def get_android_main_application_path(current_fixture)
end

Then('the Android app does not contain the bugsnag initialisation code') do
filename = get_android_main_application_path current_fixture
filename = get_android_main_application_path
step("the interactive file '#{filename}' does not contain 'import com.bugsnag.android.Bugsnag;'")
step("the interactive file '#{filename}' does not contain 'Bugsnag.start(this);'")
end
Expand Down Expand Up @@ -272,7 +272,7 @@ def get_android_main_application_path(current_fixture)
When I input "git status --porcelain" interactively
Then I wait for the interactive shell to output the following lines in stdout
"""
M #{get_android_main_application_path current_fixture}
M #{get_android_main_application_path}
M index.js
M ios/#{current_fixture}/AppDelegate.m
"""
Expand Down

0 comments on commit 11ed5c7

Please sign in to comment.