Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix electron app breadcrumb exception #1722

Merged
merged 2 commits into from
Apr 19, 2022

Commits on Apr 14, 2022

  1. Configuration menu
    Copy the full SHA
    c3525e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Fix a possible crash in app breadcrumbs plugin

    This can happen when closing a window immediately after moving it
    (i.e. within the ~250ms debounce timer). We protect against this in
    two ways:
    
    1. check if the window is destroyed before using it in the 'moved'
       callback
    2. cancel a queued call to the 'moved' callback when the 'closed'
       event fires, as this is the point where the browser window is
       destroyed
    
    The other event listeners should never be called with a destroyed
    browser window (other than 'closed') because they are not debounced
    and so run as soon as the event is emitted
    imjoehaines committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    04767f4 View commit details
    Browse the repository at this point in the history