Fix electron app breadcrumb exception #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen when closing a window immediately after moving it (i.e. within the ~250ms debounce timer). We protect against this in two ways: 1. check if the window is destroyed before using it in the 'moved' callback 2. cancel a queued call to the 'moved' callback when the 'closed' event fires, as this is the point where the browser window is destroyed The other event listeners should never be called with a destroyed browser window (other than 'closed') because they are not debounced and so run as soon as the event is emitted
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 42.31 kB |
12.94 kB |
| After | 42.31 kB |
12.94 kB |
| ± | No change | No change |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron-test-helpers/src/BrowserWindow.ts | 90.7% (-0.73%) |
75% (-3.57%) |
100% (+0%) |
91.3% (-0.81%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 81.93%(+0.02%) | 71.6%(+0.01%) | 83.21%(+0.04%) | 81.02%(+0.02%) |
djskinner
approved these changes
Apr 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To avoid collecting too many breadcrumbs we debounce the
movedevent handler, but this can cause an exception when closing a window immediately after moving it (i.e. within the ~250ms debounce timer)This PR protects against this in two ways:
movedcallbackmovedcallback when theclosedevent fires, as this is the point where the browser window is destroyedThe other event listeners should never be called with a destroyed browser window (other than
closed) because they are not debounced and so run as soon as the event is emitted