Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MacOS 10.15 build servers #1053

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Use MacOS 10.15 build servers #1053

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
786cbfd
chore(expo): remove broken and out of date build script
twometresteve Sep 18, 2020
5729ff5
ci(mac): use macOS 10.15 build queue
twometresteve Sep 18, 2020
064a3bf
ci(mac): use refined naming convention for buildkite queues
twometresteve Sep 18, 2020
9a87d34
test(expo): remove instructions for running expo tests locally on iOS
twometresteve Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/expo-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ steps:
- label: ':docker: Build expo IPA'
timeout_in_minutes: 20
agents:
queue: "opensource-mac"
queue: "opensource-mac-expo"
env:
EXPO_RELEASE_CHANNEL: ${BUILDKITE_BUILD_ID}
artifact_paths: build/output.ipa
Expand Down
4 changes: 2 additions & 2 deletions .buildkite/react-native-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ steps:

- label: ':ios: Build React-native 0.60 ipa'
agents:
queue: "opensource-mac"
queue: "opensource-mac-rn"
env:
REACT_NATIVE_VERSION: rn0.60
artifact_paths: build/rn0.60.ipa
Expand All @@ -50,7 +50,7 @@ steps:

- label: ':ios: Build React-native 0.63 ipa'
agents:
queue: "opensource-mac"
queue: "opensource-mac-rn"
env:
REACT_NATIVE_VERSION: rn0.63
artifact_paths: build/rn0.63.ipa
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"test:build-browser-container": "docker-compose up --build minimal-packager && docker-compose build --pull browser-maze-runner",
"test:build-node-container": "docker-compose up --build minimal-packager && docker-compose build --pull node-maze-runner",
"test:build-expo-android-container": "test/expo/scripts/build-android-locally.sh",
"test:build-expo-ios-container": "EXPO_RELEASE_CHANNEL=localtest test/expo/scripts/build-ios-locally.sh",
Cawllec marked this conversation as resolved.
Show resolved Hide resolved
"test:build-react-native-android-container": "test/react-native/scripts/build-android-locally.js",
"test:build-react-native-ios": "node -e 'require(\"./scripts/react-native-helper\").buildIOS()'",
"test:build-react-native-maze-runner": "docker-compose build --pull react-native-maze-runner",
Expand Down
20 changes: 0 additions & 20 deletions test/expo/scripts/build-ios-locally.sh
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions test/expo/scripts/build-ios.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@ set -e
# Lets make sure the build folder was cleared out correctly
rm -rf $BUILDKITE_BUILD_CHECKOUT_PATH/build/*
cd test/expo/features/fixtures/test-app
npm i turtle-cli@0.14 bunyan
perl -0777 -i.original -pe "s/entitlements\\['aps-environment'\\] =[^;]+;//gs" node_modules/\@expo/xdl/build/detach/IosNSBundle.js
Cawllec marked this conversation as resolved.
Show resolved Hide resolved
perl -0777 -i.original -pe "s/entitlements\\['aps-environment'\\] =[^;]+;//gs" node_modules/turtle-cli/node_modules/\@expo/xdl/build/detach/IosNSBundle.js
node_modules/.bin/turtle build:ios \
turtle build:ios \
-c ./app.json \
--team-id $APPLE_TEAM_ID \
--dist-p12-path $EXPO_P12_PATH \
Expand Down