Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MacOS 10.15 build servers #1053

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Conversation

twometresteve
Copy link
Contributor

Goal

Move the Mac-based Buildkite build steps to the new naming convention for Buildkite queues, unlocking access to our new MacOS 10.15 servers whilst maintaining access to the 10.14 servers where appropriate.

For JS, the RN steps may be serviced by either a 10.14 (while they exist) or 10.15 server. Expo steps will be served only by 10.15 servers as a result of this change, as breaking changes were needed in its setup (unable to install Turtle at the package level on 10.15 but unable to install it global on the 10.15 server).

Design

Buildkite agents running on Macs used to have a single build queue - opensource-mac. With the addition of 10.15 servers to the existing 10.14 fleet (which will be retired at some point soon) we have moved to tying agents to multiple queues, in order that we can be more targeted in which agents pick up which jobs. There are now the following queues:

  • opensource-mac (deprecated)
  • opensource-mac-cocoa
  • opensource-mac-expo
  • opensource-mac-rn

Changeset

  • (Expo) Use a global Turtle install
  • Agent queue names in the Buildkite pipelines.
  • Remove broken and outdated local iOS build script.

Testing

Naturally tested via a passing CI pipeline.

@twometresteve twometresteve requested a review from a team as a code owner September 18, 2020 21:57
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Sep 18, 2020

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against 9a87d34

package.json Show resolved Hide resolved
test/expo/scripts/build-ios.sh Show resolved Hide resolved
@twometresteve twometresteve merged commit 76af636 into next Sep 22, 2020
@twometresteve twometresteve deleted the build-ios-with-macos-10.15 branch September 22, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants