[PLAT-2110] Use deamon threads to start flushing sessions #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * This is to prevent applications from hanging waiting for the sessions scheduled task | ||
| * because deamon threads will be terminated on application shutdown | ||
| */ | ||
| public class DeamonThreadFactory implements ThreadFactory { |
There was a problem hiding this comment.
The implementation of this class could be simplified by using the decorator pattern. We could create a field for Executors.defaultThreadFactory(), then make the thread returned by threadFactory.newThread a daemon before returning. That might also make a good candidate for a unit test.
| /** | ||
| * @see ThreadFactory#newThread(Runnable) | ||
| */ | ||
| public Thread newThread(Runnable runner) { |
There was a problem hiding this comment.
This is missing an override annotation
| /** | ||
| * Constructor | ||
| */ | ||
| public DeamonThreadFactory() { |
There was a problem hiding this comment.
There's a typo in the class name (Deamon -> Daemon)
| // Create a new thread which is not a deamon thread to actually flush the sessions | ||
| // This will means that the thread will not be killed | ||
| // half way through if the application shuts down | ||
| Thread nonDeamonThread = new Thread(new Runnable() { |
There was a problem hiding this comment.
We could use a cached executor e.g. Executors.newSingleThreadExecutor() rather than creating a new thread every time this is invoked.
There was a problem hiding this comment.
Added new newSingleThreadExecutor
fractalwrench
previously approved these changes
Nov 27, 2018
fractalwrench
approved these changes
Nov 27, 2018
|
This issue came up before with a single thread executor in #50 (current logic on master) - should the session flushing logic use an executor service in the same way to ensure the service doesn't hang an app? I'd just like to check that we aren't introducing a different way for the application to hang by fixing this one. |
fractalwrench
approved these changes
Nov 28, 2018
tomlongridge
added a commit
that referenced
this pull request
Nov 6, 2020
The fix to prevent a resource leak in #143 removed the task scheduler running as a daemon thread and so doesn't exit unless the application is explicitly exited (via System.exit) or the thread is explicitly stopped (via bugsnag.close). This fix should be the benefits of both #143 and #121 to gracefully shutdown in both use cases. fixes #151
tomlongridge
added a commit
that referenced
this pull request
Nov 6, 2020
The fix to prevent a resource leak in #143 removed the task scheduler running as a daemon thread and so doesn't exit unless the application is explicitly exited (via System.exit) or the thread is explicitly stopped (via bugsnag.close). This fix should be the benefits of both #143 and #121 to gracefully shutdown in both use cases. fixes #151
tomlongridge
added a commit
that referenced
this pull request
Nov 7, 2020
The fix to prevent a resource leak in #143 removed the task scheduler running as a daemon thread and so doesn't exit unless the application is explicitly exited (via System.exit) or the thread is explicitly stopped (via bugsnag.close). This fix should be the benefits of both #143 and #121 to gracefully shutdown in both use cases. fixes #151
tomlongridge
added a commit
that referenced
this pull request
Nov 9, 2020
The fix to prevent a resource leak in #143 removed the task scheduler running as a daemon thread and so doesn't exit unless the application is explicitly exited (via System.exit) or the thread is explicitly stopped (via bugsnag.close). This fix should be the benefits of both #143 and #121 to gracefully shutdown in both use cases. fixes #151
tomlongridge
added a commit
that referenced
this pull request
Nov 9, 2020
The fix to prevent a resource leak in #143 removed the task scheduler running as a daemon thread and so doesn't exit unless the application is explicitly exited (via System.exit) or the thread is explicitly stopped (via bugsnag.close). This fix should be the benefits of both #143 and #121 to gracefully shutdown in both use cases. Updated the Spring Boot app test and example to remove explict System.exit call as this should not be required. fixes #151
tomlongridge
added a commit
that referenced
this pull request
Nov 9, 2020
The fix to prevent a resource leak in #143 removed the task scheduler running as a daemon thread and so doesn't exit unless the application is explicitly exited (via System.exit) or the thread is explicitly stopped (via bugsnag.close). This fix should be the benefits of both #143 and #121 to gracefully shutdown in both use cases. Updated the Spring Boot app test and example to remove explict System.exit call as this should not be required. fixes #151
tomlongridge
added a commit
that referenced
this pull request
Nov 9, 2020
The fix to prevent a resource leak in #143 removed the task scheduler running as a daemon thread and so doesn't exit unless the application is explicitly exited (via System.exit) or the thread is explicitly stopped (via bugsnag.close). This fix should be the benefits of both #143 and #121 to gracefully shutdown in both use cases. Updated the Spring Boot app test and example to remove explict System.exit call as this should not be required. fixes #151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In some cases the Bugsnag notifier can prevent clean application shutdowns due to the session flushing threads that are running.
This changes the threads to be marked as "deamon" so that the application can terminate without waiting for them to finish
The deamon threads run every 60 seconds to flush sessions created during that time. New threads are used to actually perform the flushing which are not marked as deamon so that they won't get killed part way though sending data.
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: